Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dragging rows #861

Merged
merged 4 commits into from
Aug 26, 2024
Merged

fix: dragging rows #861

merged 4 commits into from
Aug 26, 2024

Conversation

Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented Aug 26, 2024

No description provided.

@Sky-FE Sky-FE requested a review from tea-artist August 26, 2024 09:18
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10557116764

Details

  • 17 of 31 (54.84%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 83.336%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/record/open-api/record-open-api.controller.ts 4 11 36.36%
apps/nestjs-backend/src/features/record/open-api/record-open-api.service.ts 13 20 65.0%
Totals Coverage Status
Change from base Build 10553028477: -0.02%
Covered Lines: 30791
Relevant Lines: 36948
💛 - Coveralls

@Sky-FE Sky-FE merged commit 191216c into develop Aug 26, 2024
7 of 8 checks passed
@Sky-FE Sky-FE deleted the fix/row-drag branch August 26, 2024 09:41
AliceLanniste pushed a commit to AliceLanniste/teable that referenced this pull request Sep 1, 2024
@Sky-FE @AliceLanniste
fix: dragging rows (teableio#861)
4899853 
* feat: supplement update records API

* fix: the drag-and-drop issues with the Kanban cards

* fix: the cell value rendering issue when expanding record in the sharing view

* fix: dragging rows across groups when grouping in the grid view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sky-FE @CLAassistant @coveralls @tea-artist