Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spotless #15

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Add spotless #15

merged 7 commits into from
Nov 15, 2023

Conversation

BBScholar
Copy link
Collaborator

Added spotless check to repo. Will check if code is formatted correctly on push and merge.

One can call the ./gradlew spotlessApply to allow spotless to reformat code automatically.
Call ./gradlew spotlessCheck to check if formatting is correct.

@grappell
Copy link
Collaborator

Is there a way to do spotless apply on build? Honestly I feel like it could get in the way if we constantly have to run spotlessApply every 3 seconds

@BBScholar
Copy link
Collaborator Author

You won't need to run spotlessApply constantly. I plan on preventing someone from pushing unless the code is formatted correctly. Shouldn't matter for deploy.

I can definitely force spotlessApply to run before build though.

@BBScholar
Copy link
Collaborator Author

Probably ready to send this.

@grappell
Copy link
Collaborator

Sick, thanks

@grappell grappell merged commit 1947aba into master Nov 15, 2023
2 checks passed
@grappell grappell deleted the dev/spotless branch November 15, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants