improvement(build), log stack trace of errors thrown by build-tasks (#…

…8783)
teambit · Apr 15, 2024 · 7439e00 · 7439e00
1 parent 81211ee
commit 7439e00
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/scopes/pipelines/builder/build-pipe.ts b/scopes/pipelines/builder/build-pipe.ts
@@ -81,7 +81,7 @@ export class BuildPipe {
     await mapSeries(this.tasksQueue, async ({ task, env }) => this.executeTask(task, env));
     this.longProcessLogger.end();
     const capsuleRootDir = Object.values(this.envsBuildContext)[0]?.capsuleNetwork.capsulesRootDir;
-    const tasksResultsList = new TaskResultsList(this.tasksQueue, this.taskResults, capsuleRootDir);
+    const tasksResultsList = new TaskResultsList(this.tasksQueue, this.taskResults, capsuleRootDir, this.logger);
     await this.executePostBuild(tasksResultsList);
 
     return tasksResultsList;

diff --git a/scopes/pipelines/builder/task-results-list.ts b/scopes/pipelines/builder/task-results-list.ts
@@ -1,4 +1,5 @@
 import chalk from 'chalk';
+import { Logger } from '@teambit/logger';
 import { BitError } from '@teambit/bit-error';
 import { BuildTaskHelper } from './build-task';
 import { TasksQueue } from './tasks-queue';
@@ -13,14 +14,17 @@ export class TaskResultsList {
      */
     public tasksResults: TaskResults[],
 
-    public capsuleRootDir: string
+    public capsuleRootDir: string,
+
+    private logger: Logger
   ) {}
 
   hasErrors(): boolean {
     return this.tasksResults.some((taskResult) => taskResult.componentsResults.find((c) => c.errors?.length));
   }
 
   throwErrorsIfExist() {
+    this.logStackTrace();
     const errorMessage = this.getErrorMessageFormatted();
     if (errorMessage) {
       throw new BitError(errorMessage);
@@ -30,7 +34,7 @@ export class TaskResultsList {
   /**
    * group errors from all tasks and show them nicely to the user
    */
-  public getErrorMessageFormatted(): string | null {
+  getErrorMessageFormatted(): string | null {
     const tasksErrors: string[] = [];
     let totalErrors = 0;
     this.tasksResults.forEach((taskResult) => {
@@ -65,4 +69,19 @@ export class TaskResultsList {
     const errors = rawErrors.map((e) => (typeof e === 'string' ? e : e.toString()));
     return `component: ${componentResult.component.id.toString()}\n${errors.join('\n')}`;
   }
+
+  private logStackTrace() {
+    this.tasksResults.forEach((taskResult) => {
+      taskResult.componentsResults.forEach((componentResult) => {
+        componentResult.errors?.forEach((error) => {
+          if (error instanceof Error) {
+            this.logger.error(
+              `failed running task ${taskResult.task.name} on ${componentResult.component.id.toString()}`,
+              error
+            );
+          }
+        });
+      });
+    });
+  }
 }