fix(bit-aspect-update): indicate in the output when components are up…

… to date (#6566)

Currently it shows a misleading message: "unable to find any component that use ..."

e2e/harmony/aspect.e2e.ts

@@ -100,6 +100,11 @@ describe('aspect', function () {
       expect(show).to.have.string(`${helper.scopes.remote}/[email protected]`);
       expect(show).not.to.have.string(`${helper.scopes.remote}/[email protected]`);
     });
+    it('running the same command again, should not show a message that no component is using this aspect', () => {
+      const secondRun = helper.command.updateAspect(`${helper.scopes.remote}/my-aspect`);
+      expect(secondRun).to.have.string('are already up to date');
+      expect(secondRun).to.not.have.string('unable to find any component');
+    });
     it('bit tag should save only the updated aspect and not the old one', () => {
       helper.command.importComponent('my-aspect'); // otherwise, the tag will try to get it as a package
       helper.command.tagAllComponents();

scopes/harmony/aspect/aspect.cmd.ts

@@ -105,9 +105,16 @@ export class UpdateAspectCmd implements Command {
   constructor(private aspect: AspectMain) {}
 
   async report([aspectId, pattern]: [string, string]) {
-    const results = await this.aspect.updateAspectsToComponents(aspectId, pattern);
-    if (!results.length) return chalk.yellow(`unable to find any component that use ${chalk.bold(aspectId)}`);
-    return chalk.green(`the following component(s) have been successfully updated:\n${results.join('\n')}`);
+    const { updated, alreadyUpToDate } = await this.aspect.updateAspectsToComponents(aspectId, pattern);
+    if (updated.length) {
+      return chalk.green(`the following component(s) have been successfully updated:\n${updated.join('\n')}`);
+    }
+    if (alreadyUpToDate.length) {
+      return chalk.green(
+        `all ${alreadyUpToDate.length} component(s) that use this aspect are already up to date. nothing to update`
+      );
+    }
+    return chalk.yellow(`unable to find any component that use ${chalk.bold(aspectId)}`);
   }
 }
 

scopes/harmony/aspect/aspect.main.runtime.ts

@@ -145,7 +145,10 @@ export class AspectMain {
     };
   }
 
-  async updateAspectsToComponents(aspectId: string, pattern?: string): Promise<ComponentID[]> {
+  async updateAspectsToComponents(
+    aspectId: string,
+    pattern?: string
+  ): Promise<{ updated: ComponentID[]; alreadyUpToDate: ComponentID[] }> {
     let aspectCompId = await this.workspace.resolveComponentId(aspectId);
     if (!aspectCompId.hasVersion()) {
       try {
@@ -159,11 +162,16 @@ export class AspectMain {
     }
     const allCompIds = pattern ? await this.workspace.idsByPattern(pattern) : await this.workspace.listIds();
     const allComps = await this.workspace.getMany(allCompIds);
+    const alreadyUpToDate: ComponentID[] = [];
     const updatedComponentIds = await Promise.all(
       allComps.map(async (comp) => {
         const aspect = comp.state.aspects.get(aspectCompId.toStringWithoutVersion());
         if (!aspect) return undefined;
-        if (aspect.id.version === aspectCompId.version) return undefined; // nothing to update
+        if (aspect.id.version === aspectCompId.version) {
+          // nothing to update
+          alreadyUpToDate.push(comp.id);
+          return undefined;
+        }
         // don't mark with minus if not exist in .bitmap. it's not needed. when the component is loaded, the
         // merge-operation of the aspects removes duplicate aspect-id with different versions.
         await this.workspace.removeSpecificComponentConfig(comp.id, aspect.id.toString(), false);
@@ -172,7 +180,7 @@ export class AspectMain {
       })
     );
     await this.workspace.bitMap.write();
-    return compact(updatedComponentIds);
+    return { updated: compact(updatedComponentIds), alreadyUpToDate };
   }
 
   /**