fix(docs): gracefully handle missing compositions (#9093)

teambit · Aug 6, 2024 · cab93bb · cab93bb
1 parent 7e381e5
commit cab93bb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/scopes/docs/docs/docs.preview.runtime.tsx b/scopes/docs/docs/docs.preview.runtime.tsx
@@ -9,7 +9,7 @@ export type DocsRootProps = {
   Provider: React.ComponentType | undefined;
   componentId: string;
   docs: Docs | undefined;
-  compositions: any;
+  compositions?: any;
   context: RenderingContext;
 };
 
@@ -25,10 +25,11 @@ export class DocsPreview {
     componentId: ComponentID,
     envId: string,
     modules: PreviewModule,
-    [compositions]: [any],
+    [compositionsFromParams]: [any],
     context: RenderingContext
   ) => {
     const docsModule = this.selectPreviewModel(componentId.fullName, modules);
+    const compositions = compositionsFromParams || [];
 
     const mainModule = modules.modulesMap[envId] || modules.modulesMap.default;
     let defaultExports = mainModule.default;

diff --git a/scopes/html/html/html-docs-app.ts b/scopes/html/html/html-docs-app.ts
@@ -3,7 +3,7 @@ import { DocsRootProps } from '@teambit/docs';
 import DocsRoot from '@teambit/react.ui.docs-app';
 import { htmlToReact } from './html-to-react';
 
-const htmlDocsRoot = function ({ compositions, ...rest }: DocsRootProps) {
+const htmlDocsRoot = function ({ compositions = {}, ...rest }: DocsRootProps) {
   // should be mapObject<Record<string, any>, Record<string, () => any>>
   // @ts-ignore TODO fix
   const reactCompositions = mapObject(compositions, (key, value) => [key, htmlToReact(value as HTMLElement)]);