Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importing entire collection is very slow #1710

Closed
itaymendel opened this issue Jun 5, 2019 · 1 comment · Fixed by #1851
Closed

importing entire collection is very slow #1710

itaymendel opened this issue Jun 5, 2019 · 1 comment · Fixed by #1851
Labels
area/import area/performance priority/medium

Comments

@itaymendel
Copy link
Contributor

Expected Behavior

Importing an entire collection should not feel like its hanging forever.

Actual Behavior

It seems like the process of getting all the components to import is VERY slow.
After that - the import process is rather fast. But together they are both slow.

Steps to Reproduce the Problem

  1. bit import bit.utils/*

Specifications

  • Bit version: 14.1.2
  • Node version: 11.10.0
  • npm / yarn version: 6.7.0
  • Platform: macos
davidfirst added a commit that referenced this issue Jul 24, 2019
@davidfirst
fix #1710, improve bit-import performance when importing many compone…
1951230 
…nts that have many versions by not traveling multiple times to the SSH
@davidfirst davidfirst mentioned this issue Jul 24, 2019
Merged
@davidfirst
Copy link
Member

There were two issues.

  1. performance. It took 166 seconds to complete. It has been fixed to reduce the round trips to the SSH. Now it takes 80 seconds. Among these 80 seconds, 60 seconds were used to install packages.
  2. loader message. It kept showing 'listing remote components', even when it started to import. This has been fixed as well with the commit above.

davidfirst added a commit that referenced this issue Jul 24, 2019
@davidfirst
improve import performance of multiple components with multiple versi…
97fa286 
…ons (#1851)

* fix #1710, improve bit-import performance when importing many components that have many versions by not traveling multiple times to the SSH

* fix the loader when importing with wildcards to indicate once the component list is ready and it started to import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/import area/performance priority/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve import performance of multiple components with multiple versions teambit/bit
2 participants
@davidfirst @itaymendel