Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve the issue with direct import of a dependency #517

Closed
davidfirst opened this issue Jan 1, 2018 · 0 comments
Closed

solve the issue with direct import of a dependency #517

davidfirst opened this issue Jan 1, 2018 · 0 comments
Assignees
@davidfirst
Labels
area/import priority/high type/feature

Comments

@davidfirst
Copy link
Member

davidfirst commented Jan 1, 2018 •
edited
Loading

This is the main issue, this epic is trying to solve.

For example, a component is-string depends on another component is-type.
A user imported is-string, which also saved is-type as an NPM package. Later on, the user imports is-type directly ('bit import is-type') in order to update it.

We have to make sure that 'is-string' links are pointing to the newly imported 'is-type' and not to the old npm package.
@davidfirst davidfirst added this to the 12.1.17 milestone Jan 1, 2018
@davidfirst davidfirst self-assigned this Jan 1, 2018
davidfirst added a commit that referenced this issue Jan 2, 2018
@davidfirst
resolve #517, when a nested dependency is imported directly, re-link …
9c95b08 
…all its dependents
@ghost ghost added the review label Jan 2, 2018
@ghost ghost removed the review label Jan 3, 2018
@GiladShoham GiladShoham removed this from the 12.1.17 milestone Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfirst davidfirst

Labels
area/import priority/high type/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidfirst @GiladShoham