fix: avoid throwing ComponentNotFound when .bitmap has a non-exist version on the scope #6496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happens when an exported component has a local tag and
.bitgot deleted. The local scope doesn't have this local tag anymore and it never reached the remote.Previously, this use-case was handled by the out-of-sync algorithm, which synced the version according to the remote.
Since Harmony, a new load-hook was added before the out-of-sync logic, which imports components from remotes. This import threw ComponentNotFound in this case.
This PR fixes it by running some of the out-of-sync before the on-load hook gets called.