fix: download artifacts from unmerged-lane-id when applicable #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
approved these changes
Oct 12, 2022
davidfirst
added a commit
that referenced
this pull request
Oct 14, 2022
Instead, on the client side, check whether some objects are missing and throw an error with details from all remotes. Besides the improvement in the error-message (which now includes more data), this is a preparation for a future change of getting the same hashes from multiple remotes. It's needed for cases like #6537. Where it's not clear in what scope the objects are. With this ability it's possible to ask from all candidate remotes for the objects, and only if it's missing from all of them it throws an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an artifacts is needed, Bit goes to the lane-remote or main-remote depends whether this version is on the lane.
In case a component is during merge, its aspects config/data consist of both: the current version and the merged version, as such, it's hard to know where to get the artifacts from. the current-version scope or the merged-version scope.
This PR attempts to go to the merged-scope first, and then to the current-version scope.