add artifacts drawer to code tab #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto component-artifacts-drawer
…nto component-artifacts-drawer
odedre
approved these changes
Oct 19, 2022
| @@ -1662,42 +1674,6 @@ | |||
| "mainFile": "index.ts", | |||
| "rootDir": "scopes/design/ui/pill-label" | |||
| }, | |||
| "ui/pipelines/artifacts-panel": { | |||
| onToggle={onToggle} | ||
| name={name} | ||
| className={styles.dependencyDrawer} | ||
| contentClass={styles.dependencyDrawerContent} |
There was a problem hiding this comment.
add TODO to move the overflow: auto to DrawerUi so all will get this by default
| @@ -1,7 +1,7 @@ | |||
| import { ComponentAspect, ComponentUI } from '@teambit/component'; | |||
| import { UIRuntime } from '@teambit/ui'; | |||
| import React from 'react'; | |||
| import { SlotRegistry, Slot } from '@teambit/harmony'; | |||
| import { Harmony, SlotRegistry, Slot } from '@teambit/harmony'; | |||
There was a problem hiding this comment.
import Harmony as type in all places
| @@ -1,7 +1,7 @@ | |||
| import { ComponentAspect, ComponentUI } from '@teambit/component'; | |||
| import { UIRuntime } from '@teambit/ui'; | |||
| import React from 'react'; | |||
| import { SlotRegistry, Slot } from '@teambit/harmony'; | |||
| import { Harmony, SlotRegistry, Slot } from '@teambit/harmony'; | |||
There was a problem hiding this comment.
import Harmony as type in all places you can
| }; | ||
| } | ||
|
|
||
| export function FileTreeNode(props: TreeNodeProps<any>) { |
| if (artifactFile) { | ||
| return ( | ||
| <div className={styles.artifactWidgets}> | ||
| {/* <Icon className={styles.icon} of="open-tab" onClick={(e) => fileNodeClicked(files, 'new tab')(e, node)} /> */} |
| @@ -18,8 +18,9 @@ | |||
| user-select: none; | |||
| font-weight: bold; | |||
| padding: 0 8px; | |||
|
|
|||
| line-height: 16px; | |||
There was a problem hiding this comment.
consider changing to 1em. so if we change the font size to 20px it will still look good
| @@ -72,6 +73,7 @@ | |||
| flex: 1 1; | |||
| transition: max-height 300ms ease-in-out; | |||
| max-height: 0; | |||
| line-height: 16px; | |||
| @@ -9,6 +9,7 @@ | |||
| user-select: none; | |||
| font-weight: bold; | |||
| font-size: inherit; | |||
| line-height: 16px; | |||
| @@ -8,7 +8,7 @@ | |||
| padding-right: 8px; | |||
| font-size: inherit; | |||
| font-size: var(--bit-p-xs); | |||
|
|
|||
| line-height: 16px; | |||
odedre
approved these changes
Oct 19, 2022
…nto component-artifacts-drawer
…nto component-artifacts-drawer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes