Aspects Page: Expand/Collapse nested objects + Copy JSON #6563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luvkapur
changed the title
GiladShoham
approved these changes
Oct 19, 2022
odedre
approved these changes
Oct 19, 2022
| } | ||
|
|
||
| .toolbar { | ||
| flex-direction: row; |
There was a problem hiding this comment.
row is by default. I think you can remove this line
| } | ||
| .copyIcon { | ||
| display: flex; | ||
| font-size: var(--bit-p-xs); |
| box-sizing: border-box; | ||
| border: none; | ||
| background-color: var(--bit-bg-color-highlight); | ||
| color: var(--bit-accent-color); |
| @@ -11,12 +16,10 @@ export type AspectBoxProps = { | |||
| data: any; | |||
| } & React.HTMLAttributes<HTMLDivElement>; | |||
|
|
|||
| const collapsedIcon = 'https://static.bit.dev/bit-icons/collapse.svg'; | |||
| const expandIcon = 'https://static.bit.dev/bit-icons/expand.svg'; | |||
There was a problem hiding this comment.
we're doing the same in component drawer so maybe we can make a component and use in both?
| * @todo extract to a separate component | ||
| */ | ||
|
|
||
| function DisplayJsonTree({ object, title }: { object: any; title: string }) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes