Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lanes: Lane Compare + SnapsDistance GQL API #7011

Merged
merged 10 commits into from
Feb 7, 2023
Merged

Conversation

luvkapur
Copy link
Member

@luvkapur luvkapur commented Feb 7, 2023

Proposed Changes

  • Add Compare tab to the Lane Page
    • Allows comparing a lane with another lane
    • default to main for non main lanes, and the first non main lane for main
    • hidden if the scope has only (1) lane
  • Fix diffStatus API on lanes.main.runtime.
    • Allow diffing when source lane is main
    • When comparing two lanes, diff the sourceHead with the last commonSnap instead of head on target
  • Add snapDistance to LaneComponentDiffStatus result
    • query common snaps, sourceOnly or targetOnly snaps between components in source and target lane
Screen.Recording.2023-02-07.at.11.10.50.AM.mov

@luvkapur luvkapur changed the title Lanes: SnapsDistance GQL API Lanes: Lane Compare + SnapsDistance GQL API Feb 7, 2023
davidfirst
davidfirst previously approved these changes Feb 7, 2023
@luvkapur luvkapur enabled auto-merge (squash) February 7, 2023 17:38
@luvkapur luvkapur merged commit 78f1b1b into master Feb 7, 2023
@luvkapur luvkapur deleted the lanes/compare-fixes branch February 7, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants