Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to load envs first when loading a list of aspects #7179

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Make sure to load envs first when loading a list of aspects #7179

merged 1 commit into from
Mar 21, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Mar 21, 2023 •
edited
Loading

Proposed Changes

  • when loading a list of aspects and the list contains envs of other aspects of the list, make sure to first load the envs into harmony before loading the rest of the aspects.

@GiladShoham GiladShoham enabled auto-merge (squash) March 21, 2023 13:16
@GiladShoham GiladShoham merged commit 27e10e8 into master Mar 21, 2023
@GiladShoham GiladShoham deleted the ws-aspect-loading-envs-first branch March 21, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysaar223 guysaar223 guysaar223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiladShoham @guysaar223