Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes(Component UI + Compare): ui fixes #7279

Merged
merged 16 commits into from
Apr 20, 2023
Merged

fixes(Component UI + Compare): ui fixes #7279

merged 16 commits into from
Apr 20, 2023

Conversation

luvkapur
Copy link
Member

@luvkapur luvkapur commented Apr 17, 2023 •
edited
Loading

Proposed Changes

  • Allow passing routes to Component to override the slot
  • Add isFullScreen to ComponentCompareContext and ComponentCompareProps
  • Update CodeCompareView to use isFullScreen from ComponentCompareContext and remove dependency from LaneCompareContext
  • Update all Component Compare UI comps to the updated context
  • Update CodeCompare to allow resizing file explorer
  • Disable scrolling in ComponentPreview in ComponentOverview

@luvkapur luvkapur requested a review from odedre April 17, 2023 16:09
@luvkapur luvkapur requested a review from ranm8 April 18, 2023 19:48
@luvkapur luvkapur enabled auto-merge (squash) April 19, 2023 13:58
ranm8
ranm8 previously approved these changes Apr 19, 2023
View reviewed changes
@luvkapur luvkapur requested a review from ranm8 April 19, 2023 20:33
@luvkapur luvkapur disabled auto-merge April 19, 2023 21:51
@luvkapur luvkapur enabled auto-merge (squash) April 19, 2023 21:51
@luvkapur luvkapur merged commit 342e1da into master Apr 20, 2023
@luvkapur luvkapur deleted the compare-fixes branch April 20, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranm8 ranm8 ranm8 approved these changes

@odedre odedre Awaiting requested review from odedre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luvkapur @ranm8