Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(fork) - explicitly don't copy pkg config when forking component #7495

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Jun 5, 2023

Proposed Changes

  • before this change, any aspect can decide if it should be copied during bit fork.
    with this change, it's hardcoded configured for the pkg aspect.
  • this is required in order to support bit config set default_resolve_envs_from_roots true for bit new. otherwise, we are trying to load envs from the workspace before they are installed. so the entire bit new command is failing.

guysaar223
guysaar223 previously approved these changes Jun 5, 2023
@GiladShoham GiladShoham enabled auto-merge (squash) June 5, 2023 14:47
@GiladShoham GiladShoham disabled auto-merge June 5, 2023 17:34
@GiladShoham GiladShoham merged commit 2c08658 into master Jun 5, 2023
@GiladShoham GiladShoham deleted the fork-copy-config branch June 5, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants