Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set issues aspect as optional #7549

Merged
merged 2 commits into from
Jun 20, 2023
Merged

set issues aspect as optional #7549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5b9a68
set issues aspect as optional
guysaar223 Jun 20, 2023
3bc33cc
Merge branch 'master' into fix/set-issue-as-optional
guysaar223 Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scopes/envs/envs/environments.main.runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,7 +1028,7 @@ export class EnvsMain {
const logger = loggerAspect.createLogger(EnvsAspect.id);
const envs = new EnvsMain(config, context, envSlot, logger, servicesRegistry, component, loggerAspect, worker);
component.registerShowFragments([new EnvFragment(envs)]);
issues.registerAddComponentsIssues(envs.addNonLoadedEnvAsComponentIssues.bind(envs));
if (issues) issues.registerAddComponentsIssues(envs.addNonLoadedEnvAsComponentIssues.bind(envs));

const envsCmd = new EnvsCmd(envs, component);
envsCmd.commands = [new ListEnvsCmd(envs, component), new GetEnvCmd(envs, component)];
Expand Down
2 changes: 1 addition & 1 deletion scopes/explorer/insights/insights.main.runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class InsightsMain {
// TODO - get user-defined insights as well, and use them when instantiating InsightManager and InsightsCmd
const insightManager = new InsightManager(initialInsights);
const insightsMain = new InsightsMain(insightManager);
issues.registerAddComponentsIssues(insightsMain.addInsightsAsComponentIssues.bind(insightsMain));
if (issues) issues.registerAddComponentsIssues(insightsMain.addInsightsAsComponentIssues.bind(insightsMain));
const insightsCmd = new InsightsCmd(insightsMain);
cli.register(insightsCmd);
return insightsMain;
Expand Down