Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aspects) - fix filtering the loading of user aspect when intersect with local scope aspects (file://) #7555

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Jun 21, 2023

Proposed Changes

  • when loading user aspects we used to filter them if they also local scope aspects (using the file:// protocol). this filter was done based on checking the user aspect with the path to the local aspect.
    This filter might result in wrong filters (for example when trying to load teambit.node/node we check if node exist in the path of the local aspect (which many times is true because we have node_modules in the path). this check is bad.
    Now when filtering we are comparing the user aspects with the ids from the .aspect file of the local aspect.

@GiladShoham GiladShoham enabled auto-merge (squash) June 21, 2023 12:26
@GiladShoham GiladShoham merged commit 3919f7e into master Jun 21, 2023
@GiladShoham GiladShoham deleted the local-scope-aspects-ids branch June 21, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants