fix(aspects) - fix filtering the loading of user aspect when intersect with local scope aspects (file://) #7555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
file://
protocol). this filter was done based on checking the user aspect with the path to the local aspect.This filter might result in wrong filters (for example when trying to load
teambit.node/node
we check ifnode
exist in the path of the local aspect (which many times is true because we havenode_modules
in the path). this check is bad.Now when filtering we are comparing the user aspects with the ids from the
.aspect
file of the local aspect.