Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User agent hook fix #7577

Merged
merged 11 commits into from
Jun 29, 2023
Merged

User agent hook fix #7577

merged 11 commits into from
Jun 29, 2023

Conversation

odedre
Copy link
Member

@odedre odedre commented Jun 26, 2023

Proposed Changes

  • expose another context in user agent hook for controlling user agent device in scope page etc.
    it is used for controlling the collapse of the split pane panels in mobile res on bit cloud's end

@odedre odedre requested review from GiladShoham and ranm8 June 26, 2023 08:55
GiladShoham
GiladShoham previously approved these changes Jun 26, 2023
View reviewed changes
@ranm8 ranm8 enabled auto-merge (squash) June 28, 2023 16:26
@luvkapur luvkapur merged commit 5fef5ef into master Jun 29, 2023
@luvkapur luvkapur deleted the user-agent-hook-fix branch June 29, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranm8 ranm8 ranm8 approved these changes

@luvkapur luvkapur luvkapur approved these changes

@GiladShoham GiladShoham GiladShoham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odedre @ranm8 @GiladShoham @luvkapur