Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-server): add managed paths #7713

Merged
merged 29 commits into from
Aug 18, 2023
Merged

feat(dev-server): add managed paths #7713

merged 29 commits into from
Aug 18, 2023

Conversation

leimonio
Copy link
Contributor

@leimonio leimonio commented Jul 28, 2023

These are preparatory changes before starting using webpack cache. Webpack cache needs to be aware of which paths are not able to be cached. For that purpose we are utilising snapshot.managedPaths.

Proposed Changes

  • Generate managed paths regular expression from workspace
  • Regenerate managed paths when components are added or removed in the workspace
  • Add managed paths in the webpack dev mode configuration
  • Update and use package excluder node module pattern creation
    • Pattern generation for both Jest and Webpack
    • Each pattern target has different matching paths and strategies
    • Support windows paths
    • Type inference based on the pattern target
  • Limit webpack dev server logs to errors only

zkochan
zkochan previously approved these changes Aug 7, 2023
GiladShoham
GiladShoham previously approved these changes Aug 14, 2023
@leimonio leimonio enabled auto-merge (squash) August 18, 2023 08:59
@leimonio leimonio merged commit d8987f1 into master Aug 18, 2023
@leimonio leimonio deleted the feat/add-managed-paths branch August 18, 2023 10:46
luvkapur pushed a commit that referenced this pull request Aug 21, 2023
These are preparatory changes before starting using webpack cache.
Webpack cache needs to be aware of which paths are not able to be
cached. For that purpose we are utilising `snapshot.managedPaths`.

## Proposed Changes

- Generate managed paths regular expression from workspace
- Regenerate managed paths when components are added or removed in the
workspace
- Add managed paths in the webpack dev mode configuration
- Update and use package excluder node module pattern creation
  - Pattern generation for both Jest and Webpack
  - Each pattern target has different matching paths and strategies
  - Support windows paths
  - Type inference based on the pattern target
- Limit webpack dev server logs to errors only

---------

Co-authored-by: Gilad Shoham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants