fix(lane-merge), merge recovered components #7760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into merge-recovered-comp
GiladShoham
approved these changes
Aug 9, 2023
luvkapur
pushed a commit
that referenced
this pull request
Aug 21, 2023
Currently, if the checked out lane has a removed component and it is merging a lane where in that lane the component has been recovered, it won't merge the component, just skip it with a message saying the component is removed. This PR checks whether the other lane is ahead, in which case, we know that the other lane recovered the removed component, and we bring it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the checked out lane has a removed component and it is merging a lane where in that lane the component has been recovered, it won't merge the component, just skip it with a message saying the component is removed.
This PR checks whether the other lane is ahead, in which case, we know that the other lane recovered the removed component, and we bring it back.