-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: the update command should update to compatible versions by default #7809
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
698088a
feat: add compatible flag to the update command
zkochan ead3d44
Merge branch 'master' into update-compatible
GiladShoham 3e0fb57
Update get-all-policy-pkgs.ts
GiladShoham 3646a63
Merge remote-tracking branch 'origin/master' into update-compatible
zkochan 8bee1ca
install compatible versions by default
zkochan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ describe('update command', function () { | |
after(() => { | ||
helper.scopeHelper.destroy(); | ||
}); | ||
describe('updates policies', function () { | ||
describe('updates policies to latest versions', function () { | ||
describe('policies added by the user', function () { | ||
let configFile; | ||
let componentJson; | ||
|
@@ -110,6 +110,33 @@ describe('update command', function () { | |
}); | ||
}); | ||
}); | ||
describe('updates policies to compatible versions', function () { | ||
describe('policies added by deps set', function () { | ||
before(() => { | ||
helper.scopeHelper.reInitLocalScope(); | ||
helper.fixtures.populateComponents(1); | ||
helper.command.dependenciesSet('comp1', '[email protected]'); | ||
helper.command.update('--yes --compatible'); | ||
}); | ||
it('should update the version range', function () { | ||
const showOutput = helper.command.showComponentParsed('comp1'); | ||
expect(showOutput.packageDependencies['is-negative']).to.equal('1.0.1'); | ||
}); | ||
}); | ||
describe('policies added by deps set. savePrefix is present', function () { | ||
before(() => { | ||
helper.scopeHelper.reInitLocalScope(); | ||
helper.extensions.bitJsonc.addKeyValToDependencyResolver('savePrefix', '^'); | ||
helper.fixtures.populateComponents(1); | ||
helper.command.dependenciesSet('comp1', '[email protected]'); | ||
helper.command.update('--yes --compatible'); | ||
}); | ||
it('should update the version range', function () { | ||
const showOutput = helper.command.showComponentParsed('comp1'); | ||
expect(showOutput.packageDependencies['is-negative']).to.equal('^1.0.1'); | ||
}); | ||
}); | ||
}); | ||
(supportNpmCiRegistryTesting ? describe : describe.skip)('updates dependencies from the model', () => { | ||
let configFile; | ||
let npmCiRegistry: NpmCiRegistry; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the -> these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I'm not sure this definition is accurate