make lane name optional on change scope #7852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfirst
pushed a commit
that referenced
this pull request
Aug 30, 2023
--- ### Enhancement of `LaneRenameCmd` Command Functionality **Description:** Building upon the changes made in the previous PR ([#7852](#7852)), this PR proposes updates to the `LaneRenameCmd` command: 1. **Re-evaluation of Required Parameters**: - Current command definition: ```typescript name = 'rename <current-name> <new-name>'; ``` - The necessity of the `current-name` parameter is being questioned. The idea is to streamline the renaming process by potentially omitting the need to specify the current name. 2. **Command Context**: - This command is responsible for renaming a lane both locally and on the remote, provided the lane has been exported. - Definition: ```typescript description = `EXPERIMENTAL. change the lane-name locally and on the remote (if exported)`; ``` The intention behind these updates is to refine and simplify the user experience when renaming lanes. ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement of
bit lane change-scopeCommand FunctionalityDescription:
Proposed updates to the
bit lane change-scopecommand based on recent feedback:Optional Lane Name Parameter:
bit lane change-scopecommand. This proposal suggests making the<lane-name>parameter optional.Scope Change Restriction:
The proposed enhancements aim to improve the user experience and clarity of the
bit lane change-scopecommand.