Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix, convert mainFile to linux format before saving into the objects #8608

Merged
merged 2 commits into from
Mar 1, 2024
Merged

fix, convert mainFile to linux format before saving into the objects #8608

merged 2 commits into from
Mar 1, 2024

Conversation

davidfirst
Copy link
Member

In case the mainFile is in a directory, e.g. src/index.ts, on Windows it throws an error:

unable to save Version object of "my-scope/[email protected]", the mainFile src\index.ts is invalid

This PR fixes it by converting it to Linux format.

@davidfirst davidfirst merged commit 9175328 into master Mar 1, 2024
11 checks passed
@davidfirst davidfirst deleted the nested-main-file-win branch March 1, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfirst @GiladShoham