feat(cli), introduce "wait" handler for commands that never exit

scopes/harmony/api-server/api-server.main.runtime.ts

@@ -85,13 +85,13 @@ export class ApiServerMain {
     const port = options.port || 3000;
     const server = await this.express.listen(port);
 
-    // never ending promise to not exit the process (is there a better way?)
     return new Promise((resolve, reject) => {
       server.on('error', (err) => {
         reject(err);
       });
       server.on('listening', () => {
         this.logger.consoleSuccess(`Bit Server is listening on port ${port}`);
+        resolve(true);
       });
     });
   }

scopes/harmony/api-server/server.cmd.ts

@@ -15,8 +15,7 @@ export class ServerCmd implements Command {
 
   constructor(private apiServer: ApiServerMain) {}
 
-  async report(args, options: { port: number; compile: boolean }): Promise<string> {
+  async wait(args, options: { port: number; compile: boolean }) {
     await this.apiServer.runApiServer(options);
-    return 'server is running successfully'; // should never get here, the previous line is blocking
   }
 }

scopes/harmony/cli/command-runner.ts

@@ -30,6 +30,9 @@ export class CommandRunner {
       if (this.command.report) {
         return await this.runReportHandler();
       }
+      if (this.command.wait) {
+        return await this.runWaitHandler();
+      }
     } catch (err: any) {
       return handleErrorAndExit(err, this.commandName);
     }
@@ -95,6 +98,11 @@ export class CommandRunner {
     return this.writeAndExit(`${data}\n`, exitCode);
   }
 
+  private async runWaitHandler() {
+    if (!this.command.wait) throw new Error('runReportHandler expects command.wait to be implemented');
+    await this.command.wait(this.args, this.flags);
+  }
+
   /**
    * the loader and logger.console write output to the console during the command execution.
    * for internals commands, such as, _put, _fetch, the command.loader = false.

src/cli/command.ts

@@ -104,13 +104,21 @@ export interface Command {
   render?(args: CLIArgs, flags: Flags): Promise<RenderResult | React.ReactElement>;
 
   /**
-   * Command handler which is called for legacy commands or when process.isTTY is false
+   * Command handler which prints the return value to the console and exits.
+   * If the command has both, `render` and `report`, this one will be called when process.isTTY is false.
    * @param args  - arguments object as defined in name.
    * @param flags - command flags as described in options.
    * @return - Report object. The Report.data is printed to the stdout as is.
    */
   report?(args: CLIArgs, flags: Flags): Promise<string | Report>;
 
+  /**
+   * Command handler which never exits the process
+   * @param args  - arguments object as defined in name.
+   * @param flags - command flags as described in options.
+   */
+  wait?(args: CLIArgs, flags: Flags): Promise<void>;
+
   /**
    * Optional handler to provide a raw result of the command.
    * Will be go called if '-j'/'--json' option is provided by user.