Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor, reuse BabelCompiler class from @teambit/compilation.babel-compiler #8626

Merged
merged 4 commits into from
Mar 6, 2024
Merged

refactor, reuse BabelCompiler class from @teambit/compilation.babel-compiler #8626

merged 4 commits into from
Mar 6, 2024

Conversation

davidfirst
Copy link
Member

@davidfirst davidfirst commented Mar 5, 2024 •
edited
Loading

We currently maintaining two BabelCompiler classes, one in the core and one in teambit.compilation/babel-compiler component which is not ideal.

@davidfirst davidfirst merged commit eff80b6 into master Mar 6, 2024
11 checks passed
@davidfirst davidfirst deleted the reuse-babel-compiler branch March 6, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham GiladShoham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfirst @GiladShoham