fix(import-dependents), fix algorithm to get some missing paths #8669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfirst
changed the title
GiladShoham
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still, this is not a complete list of all paths, which can be huge and take very long to calculate (it's an NP-Hard problem).
To be able to run it in a reasonable amount of time, it's using "visitor" which helps to run each node only once.
However, this visitor caused a bug in the following scenario:
A -> B1 -> D -> E
A -> B2 -> D -> E
The traversal was done using DFS, so it started with A -> B1 all the way to E. Then, because D is already visited, it was skipping the other path [A, B2, D, E].
This PR uses BFS instead and the check for visited is done before adding to the queue.
The end result is not only more paths, but also shorter and more relevant paths due to the BFS nature.