improvement(version-history), enable generating graph as SVG without installing graphviz #8714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now to generate a graph (either for Version History or for dependencies), the GraphViz library had to be installed in the OS, which made it cumbersome especially for Windows.
This PR uses viz-js package which is basically an implementation of Graphviz in javascript. It doesn't support png/gif formats, but it does support "svg" which is superior for such graphs that can be huge. (with png trying to zoom in result in a blurry image).
In this PR, the
bit version-history graphcommand defaults to this new alternative and a new flag--pngfalls back to GraphViz.Later, the dependency graph will be updated as well.