Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix, avoid using instanceof to find a component-issue #8777

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix, avoid using instanceof to find a component-issue #8777

merged 1 commit into from
Apr 11, 2024

Conversation

davidfirst
Copy link
Member

@davidfirst davidfirst commented Apr 11, 2024 •
edited
Loading

In many cases, the component-issue is installed as a package in different places, causing the instanceof to always return false. Instead, change the implementation of getIssue to use the getIssueByName.

@davidfirst davidfirst enabled auto-merge (squash) April 11, 2024 20:18
@davidfirst davidfirst merged commit 05ced3b into master Apr 11, 2024
11 checks passed
@davidfirst davidfirst deleted the component-issues-instance-of branch April 11, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfirst @zkochan