chore: vulnerability fix - fork and componentize package-json-validator #8850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfirst
approved these changes
May 2, 2024
|
I would consider moving that component into pkg scope or dependencies scope (probably pkg is better). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forks the
package-json-validator(https://github.com/TechNickAI/package.json-validator/) and componentizes it into@teambit/pkg.package-json.validatorcomponent - which is a typescript version of the validator.The original library had security vulnerability in their cli tool which uses the
optimistdependency. This fork removes the cli portion of it (removing our dependency on the vulnerable dependency coming from the original package) and only ports the validator to typescript which we use in legacy to validate package json fields when validating versions.CR: https://bit.cloud/teambit/toolbox/~change-requests/pkg-package-json-validator