Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bit run with args #9216

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

Jinjiang
Copy link
Member

Proposed Changes

  • supported `bit run --args"

@Jinjiang
Copy link
Member Author

Update: this PR is related to this CR: https://bit.cloud/teambit/vite/~change-requests/node-cli-app-type-20240926

e.g. bit-dev run my-app --args="--a 1 --b 2" will get a CLI command with argv: [<the-node-path>, <the-app-bin-path>, '--a', '1', '--b', '2']

@@ -30,6 +31,7 @@ export class RunCmd implements Command {
['v', 'verbose', 'show verbose output for inspection and print stack trace'],
// ['', 'skip-watch', 'avoid running the watch process that compiles components in the background'],
['w', 'watch', 'watch and compile your components upon changes'],
['a', 'args [argv]', 'the arguments passing to the app.'],
Copy link
Member

@davidfirst davidfirst Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jinjiang , I guess --args flag must be provided with values. If so, change it from 'args [argv]' to 'args <argv>'.
Also, if it's possible to accept multiple args maybe describe how to enter them (e.g. wrap with quotes and separated by commas or by spaces).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I've updated the description. Feel free to adjust it to be better. 🙏

@GiladShoham GiladShoham merged commit fe3a458 into master Oct 1, 2024
11 checks passed
@GiladShoham GiladShoham deleted the jinjiang/support-run-app-with-args branch October 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants