teambit · GiladShoham · Oct 1, 2024 · Sep 30, 2024 · Sep 30, 2024 · Sep 30, 2024
diff --git a/.bitmap b/.bitmap
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -461,7 +461,7 @@ jobs:
       - restore_cache:
           key: bitsrc-registry10
       - restore_cache:
-          key: core-aspect-env-v0.0.59-v1
+          key: core-aspect-env-v0.0.60-v1
       - run: echo $BIT_FEATURES
       - run: node -v
       - run: npm -v
@@ -491,7 +491,7 @@ jobs:
           name: bbit install
           command: cd bit && bbit install
       - save_cache:
-          key: core-aspect-env-v0.0.59-v1
+          key: core-aspect-env-v0.0.60-v1
           paths:
             - /home/circleci/Library/Caches/Bit/capsules/caec9a107
       - run: cd bit && npm run link-bit-legacy
@@ -537,7 +537,7 @@ jobs:
       - restore_cache:
           key: v3-linux-bvm-folder-{{ checksum "version.txt" }}
       - restore_cache:
-          key: core-aspect-env-v0.0.59-v1
+          key: core-aspect-env-v0.0.60-v1
       # - update_ssh_agent
       # temporary, check if we can remove it
       - run: cd bit && bit cc
@@ -574,7 +574,7 @@ jobs:
       - restore_cache:
           key: v3-linux-bvm-folder-{{ checksum "version.txt" }}
       - restore_cache:
-          key: core-aspect-env-v0.0.59-v1
+          key: core-aspect-env-v0.0.60-v1
       - bit_config:
           env: "hub"
       - restore_cache:
@@ -887,7 +887,7 @@ jobs:
       - restore_cache:
           key: bitsrc-registry10
       - restore_cache:
-          key: core-aspect-env-v0.0.59-v1
+          key: core-aspect-env-v0.0.60-v1
       - run: npm view @teambit/bit version > ./version.txt
       - restore_cache:
           key: v3-linux-bvm-folder-{{ checksum "version.txt" }}

diff --git a/components/crypto/sha1/sha1.ts b/components/crypto/sha1/sha1.ts
@@ -9,5 +9,6 @@ import * as crypto from 'crypto';
  */
 // @ts-ignore todo: fix after deleting teambit.legacy
 export function sha1(data: string | Buffer, encoding: crypto.BinaryToTextEncoding = 'hex'): string {
+  // @ts-ignore should be fixed after upgrading @types/node from '12.20.4' to > 20.
   return crypto.createHash('sha1').update(data).digest(encoding);
 }
diff --git a/components/renderers/api-node-details/api-node-details.tsx b/components/renderers/api-node-details/api-node-details.tsx
@@ -77,8 +77,7 @@ export function APINodeDetails({
 
   const example = (doc?.tags || []).find((tag) => tag.tagName === 'example');
   const comment =
-    doc?.comment ??
-    doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n` ?? ''), '');
+    doc?.comment ?? doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n`), '');
   const linkComment = doc?.tags?.find((tag) => tag.tagName === 'link')?.comment;
 
   let linkPlaceholder: string | undefined;

diff --git a/components/renderers/class/class.renderer.tsx b/components/renderers/class/class.renderer.tsx
@@ -72,8 +72,7 @@ function ClassOverviewComponent(props: APINodeRenderProps) {
 
   const icon = renderer.icon;
   const description =
-    doc?.comment ??
-    doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n` ?? ''), '');
+    doc?.comment ?? doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n`), '');
   return (
     <SchemaNodesSummary
       name={classNode.name}

diff --git a/components/renderers/enum/enum.renderer.tsx b/components/renderers/enum/enum.renderer.tsx
@@ -37,8 +37,7 @@ function EnumOverviewComponent(props: APINodeRenderProps) {
 
   const icon = renderer.icon;
   const description =
-    doc?.comment ??
-    doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n` ?? ''), '');
+    doc?.comment ?? doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n`), '');
   return (
     <SchemaNodesSummary
       name={enumNode.name}

diff --git a/components/renderers/interface/interface.renderer.tsx b/components/renderers/interface/interface.renderer.tsx
@@ -39,8 +39,7 @@ function InterfaceOverviewComponent(props: APINodeRenderProps) {
 
   const icon = renderer.icon;
   const description =
-    doc?.comment ??
-    doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n` ?? ''), '');
+    doc?.comment ?? doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n`), '');
 
   return (
     <SchemaNodesSummary

diff --git a/components/renderers/react/react.renderer.tsx b/components/renderers/react/react.renderer.tsx
@@ -162,7 +162,7 @@ function ReactOverviewComponent(props: APINodeRenderProps) {
   const icon = reactRenderer.icon;
   const description =
     api.doc?.comment ??
-    api?.doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n` ?? ''), '');
+    api?.doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n`), '');
 
   return (
     <div className={styles.reactOverview}>

diff --git a/components/renderers/type-literal/type-literal.renderer.tsx b/components/renderers/type-literal/type-literal.renderer.tsx
@@ -48,8 +48,7 @@ function TypeLiteralOverviewComponent(props: APINodeRenderProps) {
 
   const icon = renderer.icon;
   const description =
-    doc?.comment ??
-    doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n` ?? ''), '');
+    doc?.comment ?? doc?.tags?.filter((tag) => tag.comment).reduce((acc, tag) => acc.concat(`${tag.comment}\n`), '');
   return (
     <SchemaNodesSummary
       name={typeLiteralNode.name ?? typeLiteralNode.toString()}

diff --git a/e2e/harmony/root-components.e2e.ts b/e2e/harmony/root-components.e2e.ts
@@ -1306,7 +1306,9 @@ module.exports.default = {
 }`
       );
       helper.extensions.addExtensionToVariant('custom-react', 'teambit.envs/env', {});
-      helper.command.install();
+      // for unclear reason, since upgrading core-envs to use @types/[email protected], the following line throws an error "Unexpected token 'export'"
+      // helper.command.install();
+      helper.command.install('--add-missing-deps');
     });
     after(() => {
       helper.scopeHelper.destroy();

diff --git a/scopes/component/checkout/checkout-version.ts b/scopes/component/checkout/checkout-version.ts
@@ -107,6 +107,7 @@ export async function applyVersion(
 export function updateFileStatus(files: SourceFile[], filesStatus: FilesStatus, componentFromFS?: ConsumerComponent) {
   files.forEach((file) => {
     const fileFromFs = componentFromFS?.files.find((f) => f.relative === file.relative);
+    // @ts-ignore should be fixed after upgrading @types/node from '12.20.4' to > 20
     const areFilesEqual = fileFromFs && Buffer.compare(fileFromFs.contents, file.contents) === 0;
     // @ts-ignore
     filesStatus[pathNormalizeToLinux(file.relative)] = areFilesEqual ? FileStatus.unchanged : FileStatus.updated;

diff --git a/scopes/defender/tester/test.cmd.ts b/scopes/defender/tester/test.cmd.ts
@@ -121,7 +121,7 @@ otherwise, only new and modified components will be tested`);
         updateSnapshot,
       });
       if (tests.hasErrors()) code = 1;
-      if (process.exitCode && process.exitCode !== 0) {
+      if (process.exitCode && process.exitCode !== 0 && typeof process.exitCode === 'number') {
         // this is needed for testers such as "vitest", where it sets the exitCode to non zero when the coverage is not met.
         code = process.exitCode;
       }

diff --git a/scopes/toolbox/performance/v8-cache/file-system-blob-store.ts b/scopes/toolbox/performance/v8-cache/file-system-blob-store.ts
@@ -125,6 +125,7 @@ export class FileSystemBlobStore {
 
   save(): boolean {
     const dump = this._getDump();
+    // @ts-ignore should be fixed after upgrading @types/node from '12.20.4' to > 20
     const blobToStore = Buffer.concat(dump[0]);
     const mapToStore = JSON.stringify(dump[1]);
 
@@ -137,6 +138,7 @@ export class FileSystemBlobStore {
     }
 
     try {
+      // @ts-ignore should be fixed after upgrading @types/node from '12.20.4' to > 20
       writeFileSync(this._blobFilename, blobToStore);
       writeFileSync(this._mapFilename, mapToStore);
     } finally {

diff --git a/scopes/workspace/config-merger/component-config-merger.ts b/scopes/workspace/config-merger/component-config-merger.ts
@@ -136,13 +136,13 @@ export class ComponentConfigMerger {
       // exist in other but not in current and base, so it got created on other.
       return { id, mergedConfig: this.getConfig(otherExt) };
     });
-    const envResult = [this.envStrategy()] || [];
+    const envResult = this.envStrategy();
     this.logger.debug(`*** end config-merger for ${this.compIdStr} ***\n`);
     return new ConfigMergeResult(
       this.compIdStr,
       this.currentLabel,
       this.otherLabel,
-      compact([...results, ...otherAspectsNotHandledResults, ...envResult])
+      compact([...results, ...otherAspectsNotHandledResults, envResult])
     );
   }