Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview) - fix bit start when having multiple versions of the same env #9244

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Oct 13, 2024

Proposed Changes

  • before this change on the ui-bundle-entry.<hash> file we have duplicate entries like:
import {CommunityReactPreview as communityEnvsCommunityReactRuntime} from '/private/tmp/design/node_modules/.bit_roots/[email protected]/node_modules/@teambit/community.envs.community-react/dist/community-react.preview.runtime.js';
import {CommunityReactPreview as communityEnvsCommunityReactRuntime} from '/private/tmp/design/node_modules/.bit_roots/[email protected]/node_modules/@teambit/community.envs.community-react/dist/community-react.preview.runtime.js';
import {CommunityReactPreview as communityEnvsCommunityReactRuntime} from '/private/tmp/design/node_modules/.bit_roots/[email protected]/node_modules/@teambit/community.envs.community-react/dist/community-react.preview.runtime.js';
import {CommunityReactPreview as communityEnvsCommunityReactRuntime} from '/private/tmp/design/node_modules/.bit_roots/[email protected]/node_modules/@teambit/community.envs.community-react/dist/community-react.preview.runtime.js';

After this change it will add the version to the target name, for example:

import {CommunityReactAspect as communityEnvsCommunityReact215Aspect} from '/private/tmp/design/node_modules/.bit_roots/[email protected]/node_modules/@teambit/community.envs.community-react/dist/community-react.aspect.js';
import {CommunityReactAspect as communityEnvsCommunityReact2113Aspect} from '/private/tmp/design/node_modules/.bit_roots/[email protected]/node_modules/@teambit/community.envs.community-react/dist/community-react.aspect.js';
import {CommunityReactAspect as communityEnvsCommunityReact1950Aspect} from '/private/tmp/design/node_modules/.bit_roots/[email protected]/node_modules/@teambit/community.envs.community-react/dist/community-react.aspect.js';
import {CommunityReactAspect as communityEnvsCommunityReact19512Aspect} from '/private/tmp/design/node_modules/.bit_roots/[email protected]/node_modules/@teambit/community.envs.community-react/dist/community-react.aspect.js';

@GiladShoham GiladShoham merged commit 1bd4f40 into master Oct 15, 2024
11 checks passed
@GiladShoham GiladShoham deleted the harmony-root-target-version branch October 15, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants