fix(rename), delete component from main upon merge when renaming on a lane #9307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, when renaming an exported component, it deletes (mark as delete) the current one and creates a new one.
Currently, when renaming on lane and this component exists on main, it deletes it only on the lane, so after merge, the main remains intact.
This PR marks the deletion on the lane with update-main flag, which knows to include the component during merge to main, which result on a deleted component on main.
Also, it fixes a bug where components on lanes that marked as update-main and the components don't exist on main, it was still merging them unnecessarily.