fix(comp loading) - fix issues with components <> envs loading with esm deps #9397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR fixes issues with install / compile / load components and envs especially when there are workspaces with ESM envs that have nested dependencies in the same workspace that need to compile to esm as well.
For example:
MyCustomEnv -> MyCustomCompiler -> MyNestedDep
all 3 components are in the workspace, and all must be compiled to esm to load properly.
Before this change we were compiling
MyCustomCompilerto esm and then theMyCustomEnvthen we tried to load theMyCustomEnvbut it failed becauseMyNestedDepwas compiled using the default env (to cjs).With this PR we build a complete dependencies graph of the envs before we compile and load.