Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(load apps) - fix cases when components not loaded as app incorrectly #9402

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix(load apps) - fix cases when components not loaded as app incorrectly #9402

merged 1 commit into from
Dec 26, 2024

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Dec 26, 2024 •
edited
Loading

Proposed Changes

  • This change will make sure that when loading apps components in a workspace we will run the load slot and the aspects to make sure:
    • we identify them as apps
    • we don't show a warning about their not-loaded envs
  • This will also fix cases when snapping components will not add the apps data into the component data

@GiladShoham GiladShoham enabled auto-merge (squash) December 26, 2024 10:31
@GiladShoham GiladShoham merged commit 4644338 into master Dec 26, 2024
10 checks passed
@GiladShoham GiladShoham deleted the load-apps-fixes branch December 26, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysaar223 guysaar223 guysaar223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiladShoham @guysaar223