Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(env get) - print npm ignore entries in env get command #9472

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Jan 16, 2025

This pull request includes changes to the PkgService class in the scopes/pkg/pkg/pkg.service.ts file to enhance the handling and display of package configuration and npm ignore entries. The most important changes include parsing the configuration JSON, extracting specific properties, and updating the rendering method to display these properties in a more structured format.

Enhancements to configuration handling and display:

  • scopes/pkg/pkg/pkg.service.ts: Modified the render method to parse the configuration JSON, extract packageJsonProps and npmIgnore, and display them with appropriate titles using chalk.
  • scopes/pkg/pkg/pkg.service.ts: Updated the getDescriptor method to include npmIgnore in the configuration object and serialize it to JSON.

@GiladShoham GiladShoham merged commit 46eaef2 into master Jan 16, 2025
10 checks passed
@GiladShoham GiladShoham deleted the envs-get-npm-ignore branch January 16, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants