Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added companies to contacts.list response #535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Brammm
Copy link

@Brammm Brammm commented Jun 8, 2020

It's currently not possible to get the company(ies) a contact is related to in the contacts.list endpoint.

@Brammm Brammm force-pushed the add-companyid-to-contacts-list branch from 929e6af to 4683a87 Compare June 8, 2020 13:55
@Brammm Brammm changed the title Added company_id to contacts.list response Added companies to contacts.list response Jun 8, 2020
Copy link
Member

@mrtus mrtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Brammm

Thank you for making this request.
As you might notice on our .list endpoints we do not always return the same information as we do in our .info. We do this on purpose to keep our .list endpoints reasonable in size and speedy.

We do want to note that this field is available on the .info endpoint.

@Brammm
Copy link
Author

Brammm commented Jun 9, 2020

Hey @mrtus

The list endpoint is paginated as it is, so I assumed performance would be less of a factor. As it stands, we are forced to call the .info endpoint for a collection of contacts, because we require the company info, which is a bunch more calls than we had hoped.

Would an optional include e.g. &includes[]=company_info or something like that be an option? We'd happily take a performance hit on the list endpoint over having to call .info multiple times.

@justijndepover
Copy link

Hi,

Is this a feature you guys are looking in to?
I'm having the same problem, where I need to do a separate call to the .info endpoint, just to get the company relation.

In my case this will result in +- 15000 extra api calls.

@Brammm
Copy link
Author

Brammm commented May 12, 2021

@justijndepover yawza. Make sure to build in some delays between requests or you're gonna be hit with rate limits as well...

@justijndepover
Copy link

Hi @mrtus

I'd like to point out that this remains an issue for me (and probably for others as well).
Do you guys plan on a solution for this?

As @Brammm mentioned, I too would prefer a performance hit instead of making thousand of extra requests.
(Which, in the end, would result in an overal slower process)

@marievandaele
Copy link

Feel free to send an email to [email protected], asking to be linked to issue ID-4236 (see related companies in return data of contacts.list). That way we can update you once this has been added to our API

@AxelDeneu
Copy link

Hello,
Sorry in advance to dig up this issue but is this planned to be implemented soon?
I'm currently having the same issue as @Brammm and having just and "include" param would be perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants