Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support both pyside2 and pyqt5 #25

Closed

Conversation

hannesdelbeke
Copy link
Collaborator

Currently bqt is tied to pyside2
If we want to use pyqt5, bqt won't work. 😞
this PR adds support for both, using Qt5

but do we want this to live inside this repo, so people can just drag n drop all code into blender and it works?
or do we want to only support pip install, and not include qt5 itself in this repo?

This needs discussion on future direction of bqt, @friedererdmann @bob-white @Amatobahn

# Conflicts:
#	bqt/blender_applications/win32_blender_application.py
@friedererdmann
Copy link
Collaborator

Hey! From the looks of it this is the abstraction is very much like Qt.py, correct? If that's the case, should we consider pushing these binding updates to Qt.py and consume from there instead?

@hannesdelbeke
Copy link
Collaborator Author

(this PR also includes sys arg passing to QT modules)
moved that to a separate PR which we can merge in first #26

@hannesdelbeke
Copy link
Collaborator Author

hannesdelbeke commented Sep 15, 2022

Hey! From the looks of it this is the abstraction is very much like Qt.py, correct? If that's the case, should we consider pushing these binding updates to Qt.py and consume from there instead?

hey, believe this might be related to a newer version of python in blender, or maybe a qt incompatibility .
I used to use qt.py for everything. so think why i didn't here was cause I ran into issues.
would have to test again since it's been a while

qt5 is more recent than qt.py
they serve the same purpose.
qt.py can handle more qt versions, but believe this is because marcus did some hacks for some of the new libs
whereas qt5 is clean without hacks

@hannesdelbeke
Copy link
Collaborator Author

hannesdelbeke commented Sep 15, 2022

@hannesdelbeke
Copy link
Collaborator Author

tbh think for now we can just leave it with pyside2, and I could remove this qt conversion from the alt tab PR.
Don't think this change is vital.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants