-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access violation fix #44
Merged
hannesdelbeke
merged 12 commits into
techartorg:master
from
hannesdelbeke:access-violation-fix
Oct 7, 2022
Merged
Access violation fix #44
hannesdelbeke
merged 12 commits into
techartorg:master
from
hannesdelbeke:access-violation-fix
Oct 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
register triggers global app, which runs create instance
hannesdelbeke
force-pushed
the
access-violation-fix
branch
from
October 7, 2022 17:28
131039c
to
6f0de5d
Compare
currently part of bqt still runs even when disabled, this commit fixes that
since bqt startup handles registration, this doesnt seem necesarry
approved by Frieder in slack |
hmm on further testing this has an issue. but if you launch a qt window, you get a different error on closing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR addresses an issue with access violation mentioned in PR #42
there is also some logic cleanup, since some funtions are called multiple times or in wrong places.
details:
QApplication is instanced, and a reference is saved in a variable in the QOperator.
the blender window is wrapped in QT, and is now managed by pyside/ the QApplication
when closing blender, operators likely get deregistered, which means the reference to QApplication is gone, and QApplication gets garbage collected.
but blender is managed by the QApp, which tries to delete all it's widgets etc.
since the operator owns qapp, qapp owns blender, and blender owns the operator. we have a loop.
moving the qapp to a global variable instead of the operator seems to fix the access violation error :D
notes
the specific commit that fixes the violation is the removal of the qoperator. replacing it with just a function