Skip to content

Commit

Permalink
Bump PHPUnit and PHP versions
Browse files Browse the repository at this point in the history
  • Loading branch information
mrliptontea committed May 10, 2024
1 parent d530b53 commit 0171670
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
5 changes: 4 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,7 @@ workflows:
matrix:
parameters:
php_version:
- 7.4
- '7.3'
- '7.4'
- '8.0'
- '8.3'
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
.idea/
atlassian-ide-plugin.xml
vendor/
.phpunit.result.cache
composer.phar
composer.lock
*-junit.xml
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
}
],
"require":{
"php": ">=5.4.0",
"php": ">=7.3",
"monolog/monolog": ">=1.5.0",
"guzzle/guzzle":"~3.7"
},
"require-dev": {
"squizlabs/php_codesniffer": "3.*",
"phpunit/phpunit": "^6.5.14",
"phpunit/phpunit": "^8.5.38",
"pear/file_marc": "1.1.2"
},
"autoload":{
Expand Down
10 changes: 5 additions & 5 deletions tests/unit/RecordTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function testParseValidXmlPackingResponse()
);
$rawData = $record->data(true);
$this->assertTrue(is_string($rawData));
$this->assertContains(
$this->assertStringContainsString(
'<srw_dc:dc xmlns:srw_dc="info:srw/schema/1/dc-schema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="info:srw/schema/1/dc-schema http://www.loc.gov/standards/sru/resources/dc-schema.xsd">',
$rawData
);
Expand All @@ -43,14 +43,14 @@ public function testParseValidStringPackingResponse()
$this->assertEquals($i + 1, $record->position());
$data = $record->data();
$this->assertInstanceOf('\DOMText', $data);
$this->assertContains(
$this->assertStringContainsString(
'<srw_dc:dc xmlns:srw_dc="info:srw/schema/1/dc-schema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="info:srw/schema/1/dc-schema http://www.loc.gov/standards/sru/resources/dc-schema.xsd">',
$data->wholeText
);

$rawData = $record->data(true);
$this->assertTrue(is_string($rawData));
$this->assertContains(
$this->assertStringContainsString(
'<srw_dc:dc xmlns:srw_dc="info:srw/schema/1/dc-schema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="info:srw/schema/1/dc-schema http://www.loc.gov/standards/sru/resources/dc-schema.xsd">',
$rawData
);
Expand All @@ -77,7 +77,7 @@ public function testParseValidMarcXmlResponse()
$this->assertTrue($data->isDefaultNamespace('http://www.loc.gov/MARC21/slim'));
$rawData = $record->data(true);
$this->assertTrue(is_string($rawData));
$this->assertContains(
$this->assertStringContainsString(
'<record xmlns="http://www.loc.gov/MARC21/slim">',
$rawData
);
Expand Down Expand Up @@ -110,7 +110,7 @@ public function testParseInvalidResponse()
$this->assertFalse($data->isDefaultNamespace('http://www.loc.gov/MARC21/slim'));
$rawData = $record->data(true);
$this->assertTrue(is_string($rawData));
$this->assertContains(
$this->assertStringContainsString(
'<recordData><leader>00953nam 2200289 4500</leader>',
$rawData
);
Expand Down

0 comments on commit 0171670

Please sign in to comment.