Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, SimpleSAMLPhp requires that a SAML signing certificate for a given SP must be configured rather than provided in the metadata that the SP publishes. It doesn't seem like something that is part of the SAML standard. Therefore, testing SAML request signing with the SimpleSAMLPhp server would require hard coding a private key in the integration test and a X509 certificate in the SimpleSAMLPhp server configuration.
Changes