- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out base and toolchain and ensure CI tests the current PR #194
Conversation
There was another bug needing to be fixed in techknowlogick#187 - /source/go.mod does not exist in go-gettable modules therefore the NAME determination will fail. Fix techknowlogick#187 Signed-off-by: Andrew Thornton <[email protected]>
Bootstrapping of arm-5, -6 and -7 currently happens in build.sh because Go will install std to /usr/local/go/pkg/linux_arm. This PR simply bootstraps these in bootstrap and moves them to /usr/local/go/pkg/linux_arm-x as appropriate with build.sh creating a symbolic link as needed. This should slightly speed up arm builds using xgo. Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
This PR substantially restructures the xgo dockers creating a separate toolchain container, go-version container and then a merged container with the build.sh and xgo. This should in future allow for more caching and to be able to avoid rebuilding the whole toolchain. Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
afd47b7
to
5ac47e4
Compare
Signed-off-by: Andrew Thornton <[email protected]>
…elevant to the toolchain Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Hopefully this might actually work in 0f2e6ff I've noticed another bug whilst working on this - I can extract out the fix if preferred. |
@techknowlogick would you be able to take a look at this? I've split base into a toolchain container containing the compilers. This toolchain is then used as the base for a bootstrapped go container which is finally then used to add xgo and the build.sh The test.yml has been extensively rewritten to ensure that the tests are run on the built container but it attempts to cache the toolchain docker if it's docker directory is unchanged. In doing this and running the tests I've noticed another bug and have also fixed that. |
Signed-off-by: Andrew Thornton <[email protected]>
…ULE="auto" Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
OK I'm convinced that this is now working and is a substantial improvement on the previous situation and fixes a number of issues therefore I'm gonna merge. |
This PR substantially restructures the xgo dockers creating a separate toolchain container, go-version container and then a merged container with the build.sh and xgo. This should in future allow for more caching and allows pr test cases to avoid rebuilding the whole toolchain.
In doing this I've noticed and fixed a number of bugs:
Fix #174
Fix #181
Fix #164
Fix #109
Signed-off-by: Andrew Thornton [email protected]