Remove .git suffix on destination directory if URL ends with it. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, the following:
homesick clone git://github.com/technicalpickles/pickled-vim.git
should produce a castle directory of:
$HOME/.homesick/repos/pickled-vim
muratayusuke
added a commit
that referenced
this pull request
Jun 17, 2013
Remove .git suffix on destination directory if URL ends with it.
|
Thank you! |
|
Woo, thanks! |
|
@fnichol just ran into this the other day, thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I ran into an issue when managing some pull requests in my Homesick Chef cookbook. It looks like for Homesick gem versions greater than 0.7.0 Git URLs ending in
.gitwill retain the suffix when the castle directory is created. I believe the regression was introduced by 376fd88.This pull request cleans up the change in behavior and adds a sanity spec to cover future refactorings.
For example, the following:
should produce a castle directory of:
Thanks for homesick, essential sanity for me when spinning up new systems 😄