Deduplicate reports over (domain, org, reportid), not just over reportid #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING: This change requires to alter your database index. Mysql: ALTER TABLE report DROP INDEX domain, ADD UNIQUE KEY domain (domain, org, reportid);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #112.
WARNING: The scheme of a running database must be changed to use the new index definition. Example for MySQL:
ALTER TABLE report DROP INDEX domain, ADD UNIQUE KEY domain (domain, org, reportid);
Any idea to automate this?
Without this change, the following failure will occur when encountering an identical (domain, reportid) tuple:
DBD::mysql::db do failed: Duplicate entry 'wander.science-wander.science.1677801600.1677888000' for key 'domain' at dmarcts-report-parser.pl line 859.
dmarcts-report-parser.pl: aperture-labs.org: wander.science.1677801600.1677888000: Cannot add report to database. Skipped.
dmarcts-report-parser.pl: Skipping IMAP message with UID #2869 due to database errors.