Skip to content
This repository has been archived by the owner on Apr 5, 2021. It is now read-only.

move editor window title logic to base class #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lshman
Copy link
Contributor

@lshman lshman commented Mar 28, 2021

Each editor has its own (slightly different) logic for setting the window title.
I have moved the logic to the base class (EditViewBase) so the window titles should be consistent.

@tedfelix
Copy link
Owner

Originally I wasn't referring to the window title. @MatrixWidget::m_segmentLabel@ is a label that appears below the matrix editor and shows both the Segment name and color for quick identification when spinning through Segments with the wheel control. We need that added to NotationWidget.

I'll take a look at this window title change when I have a chance, though.

@lshman
Copy link
Contributor Author

lshman commented Mar 28, 2021

Oh right. I read your original remark and it is actually quite clear. I don't know why I interpreted it as the window title. Still I think the window titles are more consistent now. I can try to look at the label. It is certainly a useful feature in the matrix editor !

@tedfelix
Copy link
Owner

tedfelix commented Apr 5, 2021

This branch was merged on sourceforge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants