Added Cancellable
interface to event classes using CancellableTrait
#99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this plugin only uses PocketMine-MP's
CancellableTrait
to add methods likecancel()
to its event classes to make them cancellable.But unlike the event classes of PocketMine-MP, it does not implement the
Cancellable
interface.This is problematic because without this interface implemented, PMMP's internal event handlers won't know that those events are cancellable, which can be seen here.
Because of that, it is for example not possible to use PMMP's
handleCancelled
tag on handler methods to disable the calling of your listener if the event was already cancelled. This tag can only be used, if the event class you want to listen for, implements theCancellable
interface, which can be seen here.