Make the pidfile accessible by everyone

[mcasquer]

Creates the pidfile at an accessible location
for every user, this way the manage pidfile
warning is avoided.

Pull Request Checklist

• implement the feature
• write the documentation
• extend the test coverage
• update the specification
• mention the version
• include a release note

[mcasquer]

To discuss here which of the added # noqa could be avoided

[mcasquer]

@happz one question, in the related issue with the patch it's used tmt -a provision -h local which IIUC it's the local host already executing tmt, in this case the code raises again permissions issues when doing the chmod

[happz]

@happz one question, in the related issue with the patch it's used tmt -a provision -h local which IIUC it's the local host already executing tmt, in this case the code raises again permissions issues when doing the chmod

Is your change here causing a regression? Or is your change here just making no difference WRT #2877?

[thrix]

@carlosrodfern howdy, I am the 1.42 release lead, can you please re-review if ok with you?

[mcasquer]

You could test getting the setfacl out of the if not self.workdir_root.is_dir(), or perhaps remove the condition all together:

Sorry @carlosrodfern for not replying, I removed the condition but it seems tests are still failing

[carlosrodfern]

I will take a look.

…

On Tue, Jan 21, 2025 at 1:45 AM Mario Casquero ***@***.***> wrote: You could test getting the setfacl out of the if not self.workdir_root.is_dir(), or perhaps remove the condition all together: Sorry @carlosrodfern <https://github.com/carlosrodfern> for not replying, I removed the condition but it seems tests are still failing — Reply to this email directly, view it on GitHub <#3252 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACI4T77DLUOIFWPIKHIRF7D2LYJKTAVCNFSM6AAAAABPFLAFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUGE4DOMZYGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[carlosrodfern]

@mcasquer, I created a pull request with a fix. I tested it on your changes and they pass: #3483

You can pull the commit locally and test it to verify, and then, after my PR is reviewed and merged, you can update your branch with main, and that should make this PR pass all the become container tests.