Execute must not use discover phases disabled by their when
#3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
bug
happz
requested review from
psss,
lukaszachy,
thrix,
janhavlin and
martinhoyer
as code owners
happz
force-pushed
the
execute-shall-not-use-disable-discover
branch
from
27fe736 to
29fc1e5
Compare
KwisatzHaderach
approved these changes
Jan 28, 2025
lukaszachy
approved these changes
Jan 28, 2025
lukaszachy
approved these changes
Jan 28, 2025
Yep, it's there now. It took me some time to modify and extend the existing one. |
KwisatzHaderach
approved these changes
Jan 28, 2025
thrix
added
the
status | ready for merge
thrix
force-pushed
the
execute-shall-not-use-disable-discover
branch
from
854da66 to
73cdd3b
Compare
|
/packit retest-failed |
This seems to be an omission from when `when` was added: it is evaluated by tmt, not by fmf, disabled phases are still present in the tree of steps and phases. Most places already ignore them, but `execute` did not. `execute` runs its single phase with all `discover` phases in sequence, and must make sure it does not try to run the disabled ones. Fixes #3492.
thrix
force-pushed
the
execute-shall-not-use-disable-discover
branch
from
73cdd3b to
8af4e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be an omission from when
whenwas added: it is evaluated by tmt, not by fmf, disabled phases are still present in the tree of steps and phases. Most places already ignore them, butexecutedid not.executeruns its single phase with alldiscoverphases in sequence, and must make sure it does not try to run the disabled ones.Fixes #3492.
Pull Request Checklist