Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit checks to new versions #3501

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update pre-commit checks to new versions #3501

merged 1 commit into from
Feb 4, 2025

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 30, 2025

Pull Request Checklist

  • implement the feature

@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. test coverage Improvements or additions to test coverage of tmt itself code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Jan 30, 2025
@happz happz added this to the 1.43 milestone Jan 30, 2025
@thrix
Copy link
Collaborator

thrix commented Jan 31, 2025

LGTM, see also #3504 maybe we could automate this a bit so we update it regularly once per release.

thrix
thrix approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added the ci | full test Pull request is ready for the full test execution label Feb 4, 2025
@happz happz force-pushed the bump-pre-commit-check-versions branch from ffa7e39 to 5fb213e Compare February 4, 2025 11:58
@lukaszachy lukaszachy enabled auto-merge (rebase) February 4, 2025 14:28
@lukaszachy lukaszachy merged commit 9dab7d6 into main Feb 4, 2025
20 checks passed
@lukaszachy lukaszachy deleted the bump-pre-commit-check-versions branch February 4, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @thrix @lukaszachy @therazix