Provision step should store even guests not fully provisioned

tmt/steps/provision/__init__.py

@@ -1206,6 +1206,9 @@ def show(self, show_multihost_name: bool = True) -> None:
         if self.is_dry_run:
             return
 
+        if not self.is_ready:
+            return
+
         for key, key_formatted, value_formatted in self.facts.format():
             if key in GUEST_FACTS_INFO_FIELDS:
                 self.info(key_formatted, value_formatted, color='green')
@@ -2584,15 +2587,14 @@ def wake(self, data: Optional[GuestData] = None) -> None:
             guest.wake()
             self._guest = guest
 
+    # TODO: getter. Like in Java. Do we need it?
+    @property
     def guest(self) -> Optional[Guest]:
         """
-        Return provisioned guest
-
-        Each ProvisionPlugin has to implement this method.
-        Should return a provisioned Guest() instance.
+        Return the provisioned guest.
         """
 
-        raise NotImplementedError
+        return self._guest
 
     def essential_requires(self) -> list['tmt.base.Dependency']:
         """
@@ -2704,7 +2706,7 @@ def go(self) -> Iterator['ProvisionTask']:
                     yield ProvisionTask(
                         logger=new_logger,
                         result=None,
-                        guest=None,
+                        guest=phase.guest,
                         exc=None,
                         requested_exit=exc,
                         phases=[],
@@ -2714,7 +2716,7 @@ def go(self) -> Iterator['ProvisionTask']:
                     yield ProvisionTask(
                         logger=new_logger,
                         result=None,
-                        guest=None,
+                        guest=phase.guest,
                         exc=exc,
                         requested_exit=None,
                         phases=[],
@@ -2724,7 +2726,7 @@ def go(self) -> Iterator['ProvisionTask']:
                     yield ProvisionTask(
                         logger=new_logger,
                         result=None,
-                        guest=phase.guest(),
+                        guest=phase.guest,
                         exc=None,
                         requested_exit=None,
                         phases=[],
@@ -2833,9 +2835,8 @@ def wake(self) -> None:
             # If guest data loaded, perform a complete wake up
             plugin.wake(data=self._guest_data.get(plugin.name))
 
-            guest = plugin.guest()
-            if guest:
-                self._guests.append(guest)
+            if plugin.guest:
+                self._guests.append(plugin.guest)
 
         # Nothing more to do if already done and not asked to run again
         if self.status() == 'done' and not self.should_run_again:
@@ -2905,15 +2906,10 @@ def _run_provision_phases(
 
                     failed_tasks.append(outcome)
 
-                    continue
-
-                guest = outcome.guest
-
-                if guest:
-                    guest.show()
+                if outcome.guest:
+                    outcome.guest.show()
 
-                    if guest.is_ready or self.is_dry_run:
-                        self._guests.append(guest)
+                    self._guests.append(outcome.guest)
 
             return all_tasks, failed_tasks
 

tmt/steps/provision/artemis.py

@@ -748,10 +748,3 @@ def go(self, *, logger: Optional[tmt.log.Logger] = None) -> None:
         )
         self._guest.start()
         self._guest.setup()
-
-    def guest(self) -> Optional[GuestArtemis]:
-        """
-        Return the provisioned guest
-        """
-
-        return self._guest

tmt/steps/provision/bootc.py

@@ -416,6 +416,3 @@ def go(self, *, logger: Optional[tmt.log.Logger] = None) -> None:
         )
         self._guest.start()
         self._guest.setup()
-
-    def guest(self) -> Optional[tmt.steps.provision.Guest]:
-        return self._guest

tmt/steps/provision/connect.py

@@ -232,10 +232,3 @@ def go(self, *, logger: Optional[tmt.log.Logger] = None) -> None:
             logger=self._logger, data=data, name=self.name, parent=self.step
         )
         self._guest.setup()
-
-    def guest(self) -> Optional[tmt.GuestSsh]:
-        """
-        Return the provisioned guest
-        """
-
-        return self._guest

tmt/steps/provision/local.py

@@ -236,10 +236,3 @@ def go(self, *, logger: Optional[tmt.log.Logger] = None) -> None:
 
         self._guest = GuestLocal(logger=self._logger, data=data, name=self.name, parent=self.step)
         self._guest.setup()
-
-    def guest(self) -> Optional[GuestLocal]:
-        """
-        Return the provisioned guest
-        """
-
-        return self._guest

tmt/steps/provision/mrack.py

@@ -1319,14 +1319,6 @@ def start(self) -> None:
         self.verbose('primary address', self.primary_address, 'green')
         self.verbose('topology address', self.topology_address, 'green')
 
-    def stop(self) -> None:
-        """
-        Stop the guest
-        """
-
-        # do nothing
-        return
-
     def remove(self) -> None:
         """
         Remove the guest
@@ -1449,10 +1441,3 @@ def go(self, *, logger: Optional[tmt.log.Logger] = None) -> None:
         )
         self._guest.start()
         self._guest.setup()
-
-    def guest(self) -> Optional[GuestBeaker]:
-        """
-        Return the provisioned guest
-        """
-
-        return self._guest

tmt/steps/provision/podman.py

@@ -576,10 +576,3 @@ def go(self, *, logger: Optional[tmt.log.Logger] = None) -> None:
         self._guest.facts.capabilities[GuestCapability.SYSLOG_ACTION_READ_ALL] = False
         # ... while this seems to be forbidden completely.
         self._guest.facts.capabilities[GuestCapability.SYSLOG_ACTION_READ_CLEAR] = False
-
-    def guest(self) -> Optional[GuestContainer]:
-        """
-        Return the provisioned guest
-        """
-
-        return self._guest

tmt/steps/provision/testcloud.py

@@ -1275,13 +1275,6 @@ def go(self, *, logger: Optional[tmt.log.Logger] = None) -> None:
         self._guest.start()
         self._guest.setup()
 
-    def guest(self) -> Optional[tmt.Guest]:
-        """
-        Return the provisioned guest
-        """
-
-        return self._guest
-
     def _print_local_images(self) -> None:
         """
         Print images which are already cached